feat: Make CozyPouchLink compatible with ReactNative by Ldoppea · Pull Request #1483 · linagora/cozy-client

Ldoppea · 2024-05-23T16:27:36Z

We want to reduce coupling between CozyPouchLink and the browser's
local storage

This PR adds a platform option into the PouchLink constructor in
order to allow injecting custom local storage API, PouchDB adapter, an
isOnline method and a custom event emitter for online/offline and
pause/resume events from the consuming app

This will allow to use CozyPouchLink from a react-native project where
a different PouchDB adapter is used and where none of
window.localStorage, window.navigator.onLine,
document.addEventListener and document.removeEventListener API are
available

If no custom platform is injected, then platformWeb.js will be used
by default

In order to inject a custom platform, create a new platform object
containing the same API as platformWeb.js and add it into the
PouchLink constructor's platform option

import { default as PouchLink } from 'cozy-pouch-link'

// Class based on `platformWeb.js`
import { CustomPlaftorm } from './CustomPlaftorm'

const pouchLink = new PouchLink({
  platform: new CustomPlaftorm()
})

Related PRs:

paultranvan · 2024-06-04T14:41:36Z

+export class PouchLocalStorage {
+  constructor(storageEngine) {
+    this.storageEngine = storageEngine
+  }


Maye it would be worth checking the expected methods getItem, setItem, removeItem are provided by the storage engine ?

Done in #1524

paultranvan · 2024-06-04T14:46:43Z

+    )
+    this.PouchDB = options.platform?.pouchAdapter || platformWeb.pouchAdapter
+    this.isOnline = options.platform?.isOnline || platformWeb.isOnline
+    this.events = options.platform?.events || platformWeb.events


I wonder if we should enforce some strict checking on the given options.platform as it has a lot of responsibility and it's easy to miss something

paultranvan · 2024-06-04T14:48:48Z

        // as it avoids to replicate all revs history, which can lead to
        // performances issues
-        docs = await replicateAllDocs(pouch, url, doctype)
+        docs = await replicateAllDocs(pouch, url, doctype, storage)


nit: I might be worth moving to await replicateAllDocs({pouch, url, doctype, storage})

Done in #1524

We want to reduce coupling between CozyPouchLink and the browser's local storage The first step is to groupe existing methods into a PouchLocalStorage class, this will allow (in the next commit) to inject a storage adapter into the class constructor Also in some platforms like ReactNative, the localstorage methods are asynchronous. So in order to be compatible with all platforms we want those methods to become async by default The big main of making those methods async is that we cannot call them from the `PouchManager` constructor. So we introduce a new `.init()` method in the `PouchManager` class. This async method now contains all the initialization logic and should be called after creating a new `PouchManager` As `PouchManager` is called internally by `CozyPouchLink` and is not meant to be a publicly available class, then we don't consider this as a breaking change

We want to reduce coupling between CozyPouchLink and the browser's local storage This will allow to use CozyPouchLink from a react-native project where `window.localStorage` API is not available If no custom storage is injected, then `platformWeb.js` will be used by default In order to inject a custom storage, create a new platform object containing the same API as `platformWeb.js` and add it into the PouchLink constructor's `platform` option ```js import { default as PouchLink } from 'cozy-pouch-link' // Class based on `platformWeb.js` import { CustomPlaftorm } from './CustomPlaftorm' const pouchLink = new PouchLink({ platform: new CustomPlaftorm() }) ```

In previous commit we added a `platform` option into the PouchLink constructor in order to allow injecting a custom local storage API from a react-native project We also want to inject a custom PouchDB adapter as a react-native project would use a different PouchDB implementation Like for the local storage API, if no injection is given, then `pouchdb-browser` adapter will be used by default

In previous commit we added a `platform` option into the PouchLink constructor in order to allow injecting custom local storage API and PouchDB adapter from a react-native project We also want to inject a custom `isOnline` method as react-native does not provide the `window.navigator.onLine` API Like for the other APIs, if no injection is given, then `window.navigator.onLine` will be used by default

In previous commit we added a `platform` option into the PouchLink constructor in order to allow injecting custom local storage API, PouchDB adapter and isOnline method from a react-native project We also want to inject a custom evant emitter for online/offline and pause/resume events as react-native does not provide the `document.addEventListener` and `document.removeEventListener` APIs Like for the other APIs, if no injection is given, then `document` APIs will be used by default

Crash--

Nice work!

paultranvan

Excellent work, with very good atomic commits and descriptions!